Feat: add free draw option in plots and setup update pipeline for plots - #1563
Conversation
There was a problem hiding this comment.
Sorry @rajnisht7, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Comparison tests are supposed to fail as this PR introduces visual changes |
Manik-Khajuria-5
left a comment
There was a problem hiding this comment.
@rajnisht7 Since u are working on this PR please make this pr as draft as it will be good feat and will be having lot of implementation changes
@Manik-Khajuria-5 as discussed, this PR is good to go, kindly review it |
Manik-Khajuria-5
left a comment
There was a problem hiding this comment.
@rajnisht7 LGTM! I have read backend changes and they are fine Please address failing test rest everything is good to go
@Manik-Khajuria-5 Thanks for the review, the test is supposed to fail as this PR introduces visual changes |
tonypzy
left a comment
There was a problem hiding this comment.
please resolve sourcery issues
js/api/ApiProvider.js:210 - User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
js/api/ApiProvider.js:222 - User controlled data in methods like innerHTML, outerHTML or document.write is an anti-pattern that can lead to XSS vulnerabilities
@tonypzy these are completely un-related to this PR neither these changes are introduced by this PR, we can keep this PR's scope limited to this feature only this PR introduces changes from line 323 to 332 and 391 |
|
Please fix issues flagged by sorcery in a seperate pr |
Sure, will file a PR for the same. Thank You |
Description
This PR adds an option in plotly modbar with which user can directly use a marker to draw information on pltots, and can erase it, apart from this, this PR also introduces a plot layout update pipeline.
all the drawings made on the PR, persist after closing the server too
Motivation and Context
adding a free draw option so that user can draw anything on chart
How Has This Been Tested?
started the server
made some drawings
closed the server
loaded the env
verified that drawing remained as it it
Screencast_20260706_025132.online-video-cutter.com.mp4
Types of changes
Checklist:
py/visdom/VERSIONaccording to Semantic Versioning