Open
Conversation
Create a new set of digit shapes, implemented as clones of simple objects, reducing effort for future iterations of the event. The digits were not aligned correctly to the negative space. Make them center aligned. The SVG viewbox was a little bit wider than it needed to be. Make it take the minimum required width. Fixes fossunited#9
Author
|
Things I'd like to add:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I recently needed to use the IndiaFOSS logo for this blog entry, the artifacts in #9 were bugging me. I fixed them and uploaded a local copy of the logo for the blog.
In the spirit of FOSS, I'd like to upstream the changes. I'm proposing to add a master/main file from which all other assets would be generated. I'm willing to put in more effort, but only if the changes are reasonable and genuinely needed.
I've created some digit shapes for ease of re-use. They won't be visible in any application that is not Inkscape, since they are on a different page. While doing that, I've center aligned those digits correctly, which was not the case before. They were off to the left by just a bit.
The SVG viewbox was a little bit wider than it needed to be. Now it takes the minimum size required.
I have not modified the design of the original IndiaFOSS signage in any other way (there are some things off with the main signage).
This fixes the rendering artifacts in #9
As per my understanding, those are result of anti-aliasing, which renderers do by default. The artifacts can be fixed by setting
shape-renderingtocrispEdgesin the SVG, but I believe this is a better fix.