Use ontology labels - #34
Merged
Merged
Conversation
AybukeKY
reviewed
Apr 16, 2026
AybukeKY
left a comment
AybukeKY
left a comment
There was a problem hiding this comment.
tests/test_index_transformer.py is failing during CI, and when I tried "generate-bia-rocrate" on my local, I got a connection timeout as OLS seems to be very slow currently. It's not a problem though as it's only used during generation of ro-crates not live, but adding a fail-safe option may be good.
Otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to use ontology labels (using OLS to look them up) when creating indexable document for the fields that get used for search facets (but not the rest of the document)
Added basic tests for the ro-crate -> index, index, and api, and github workflow to run them.
ticket: https://app.clickup.com/t/869cn2kre