This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Draft
Conversation
Tested in examples/single-node-asg-tester The change in all three modules is compatible with old code that defines just one data volume.
Since it is single node, binding an EIP to the instance is possible. And it eases other things since the public interface is constant. Add assign_eip variable to single-node-asg. If turns it on, an EIP will be allocated, and assocated with the instance. Scope VPC is specified in case the account does not have a default VPC.
qrilka
force-pushed
the
ec2-connect-tunnel
branch
from
8b1a636 to
3c17169
Compare
qrilka
commented
May 12, 2020
| } | ||
|
|
||
| output "eip_address" { | ||
| value = module.asg.eip_address |
Contributor
Author
There was a problem hiding this comment.
@JoseD92 this output already exists as public_ip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.
- For new
modulesthis would entail example code for how to use the module or some explanation in the module readme.- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
This PR uses #232 and #319 so needs those to be merged first