ci: match the per-JDK test-report artifacts in the results publisher - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The build-parallelization migration renamed the test-report artifact in
gradle-build.ymlfromjunit-test-resultsto per-matrix-cell names (junit-test-results-jdk${{ matrix.jdk }}), but theworkflow_run-triggered publisher inpublish-test-results.ymlstill downloads by the exact namejunit-test-resultsviadawidd6/action-download-artifact. No artifact matches, so every "Publish Test Results" run now fails.The fix
Switch the download step to a regex match (
name: junit-test-results.*withname_is_regexp: true). Withname_is_regexp, each matched artifact is extracted into a subdirectory named after itself, and the downstreamreport_paths: '**/build/test-results/test/TEST-*.xml'glob still matches inside those subdirectories — the published report now covers the results from all matrix JDKs.This repo's publisher was also lagging behind its siblings, so it is aligned to their known-working configuration:
dawidd6/action-download-artifactbumped from@v2to@v9(regex matching needs a recent version), the redundantworkflow:input dropped (implied byrun_id), and the permissions block extended withactions: read+contents: readwhich v9 needs to read the source run's artifacts.Verification caveat
workflow_runworkflows always execute the default branch's workflow definition, so this fix only takes effect after merge — this PR itself cannot demonstrate the publisher passing. The red "Publish Test Results" run that appears alongside this PR's checks is the pre-fix master definition failing, i.e. exactly the symptom this PR fixes.