fix(docs): repair dead hook reference, reconcile agent count and version drift#30
Conversation
…agent count and version drift - .claude/hooks.json: SessionStart/Notification hooks referenced a nonexistent .claude/skill-rules-v2.json, silently falling back with no real enforcement. Repointed both to the actual skill-rules.json. - CLAUDE.md, README.md: repo had 67 real agent files under .claude/agents/ (verified count) but docs still said "38 Specialized Agents" throughout, and package.json is v11.0.0 while CLAUDE.md's title/footer still said v10/v10.1. Reconciled both to reality. ACOS lint (node scripts/lint.mjs) passes clean after changes.
📝 WalkthroughWalkthroughThis PR updates ChangesSkill Rules File Reference Update
v11 Documentation Update
Estimated code review effort: 1 (Trivial) | ~5 minutes Related issues: None specified. Related PRs: None specified. Suggested labels: documentation, config Suggested reviewers: frankxai Poem A rabbit hops through docs so bright, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Agentic Creator OS from v10 to v11, which includes updating the number of specialized agents from 38 to 67 across the documentation and configuration files. Additionally, it simplifies the skill rules loader hook by switching from skill-rules-v2.json to skill-rules.json. Feedback is provided regarding the use of echo with backslash escapes in the hooks configuration, suggesting a transition to printf to ensure cross-platform shell portability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Per gemini-code-assist review on PR #30: echo with \n backslash escapes is non-portable (bash/dash print it literally, zsh interprets it). printf is consistent across shells.
There was a problem hiding this comment.
Pull request overview
Repairs ACOS documentation and hook messaging so the repo’s stated agent count/version aligns with the current reality, and removes a dead reference in hooks that pointed to a non-existent skill-rules-v2.json.
Changes:
- Update
README.mdandCLAUDE.mdto reflect ACOS v11 and the 67-agent catalog (instead of 38). - Fix
.claude/hooks.jsonmessaging to reference the actual.claude/skill-rules.jsonfile (and improve newline formatting for the notification output).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates v11 + 67-agent references in top-level docs (but leaves one remaining “38 agents” table entry; see comment). |
| CLAUDE.md | Updates v11 branding and agent count to match the current repo state. |
| .claude/hooks.json | Repoints the hook messaging from non-existent skill-rules-v2.json to the real skill-rules.json and improves output formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.claude/hooks.json (1)
14-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winStale "ACOS v10" string left alongside version reconciliation.
The
acos-context-loaderhook still prints "ACOS v10 loaded" while this PR reconciles the documented version to v11.0.0 inCLAUDE.md/README.md. If not already tracked as one of the "related repo issues... intentionally left unchanged," consider updating this too for consistency.♻️ Proposed fix
- "description": "Load ACOS v10 with model routing and skill auto-activation", + "description": "Load ACOS v11 with model routing and skill auto-activation", "type": "command", - "command": "echo 'ACOS v10 loaded | Model Routing ON | Skill Auto-Activation ON | Safety Hooks ON'", + "command": "echo 'ACOS v11 loaded | Model Routing ON | Skill Auto-Activation ON | Safety Hooks ON'",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.claude/hooks.json around lines 14 - 19, The acos-context-loader hook still emits the outdated ACOS v10 text, which conflicts with the version reconciliation in the docs. Update the command string in the acos-context-loader entry within hooks.json so the printed message matches the new v11.0.0 naming, keeping the rest of the hook behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.claude/hooks.json:
- Around line 14-19: The acos-context-loader hook still emits the outdated ACOS
v10 text, which conflicts with the version reconciliation in the docs. Update
the command string in the acos-context-loader entry within hooks.json so the
printed message matches the new v11.0.0 naming, keeping the rest of the hook
behavior unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0d0c1d42-c470-4db3-bd17-77229b411595
📒 Files selected for processing (3)
.claude/hooks.jsonCLAUDE.mdREADME.md
…Copilot review - README.md summary table, package.json description: still said "38 agents" after the first pass (Copilot review) - .claude/hooks.json acos-context-loader: still printed "ACOS v10 loaded" while docs elsewhere were reconciled to v11 (CodeRabbit nitpick)
Queen-doctrine review — verdict: READY-TO-MERGEClassification: Mechanical (docs/config drift repair). Checks green (build SUCCESS), MERGEABLE against main. Verified against origin/main:
Scope note (not blocking): this PR fixes only the agent count. The README still self-contradicts on skills/commands (header "90+/65+" vs component table "75+/35+"; actual today is 106 top-level skills / 83 top-level commands). That is #29's scope — merge this first, then #29 rebases and finishes the job. Merge order matters: this PR before #29 and before #25 (both touch the same README lines; #25 rewrites the whole file). |
Summary
Repo audit found operational docs/config drift: a dead hook reference to a nonexistent skill-rules file, and a version/agent-count mismatch between docs and reality. Fixed both.
Change Type
Frank DNA Alignment
For Structural Changes
Structural Change Checklist (expand if applicable)
Problem Definition:
CLAUDE.md,README.md,package.json) claimed "38 Specialized Agents" and "v10/v10.1" while the actual repo has 67 agent files under.claude/agents/andpackage.jsonis already11.0.0. Two.claude/hooks.jsonhooks also referenced a.claude/skill-rules-v2.jsonfile that has never existed, silently no-op'ing the "enhanced skill rules" enforcement they claimed to load.find .claude/agents -maxdepth 1 -iname '*.md'→ 67;package.json→11.0.0;test -f .claude/skill-rules-v2.json→ false.Solution Evaluation:
Risk Assessment:
The Frank Test:
Testing
node scripts/lint.mjspasses (18 skills checked, 0 errors, 0 warnings) after every changenpm testor equivalent) — no test suite covers docs/hooks.jsonRelated Issues
None — found via a repo audit, not filed as an issue first.
Also flagged during the audit but deliberately not touched here (need a human call, not a confident autonomous fix):
.claude/skills/skill-rules-v11.json— orphaned draft in the wrong location, referencing skills that don't exist (acos,baseline-ui).claude/skills/anthropic/— duplicates 14 top-level skills verbatim; unclear if intentional vendoring or driftCLAUDE.mddocuments things like/office-hoursas slash commands, but they're implemented as skills under.claude/skills/gstack/🤖 Generated with Claude Code