Skip to content

[Updated] Phase 1 #1: Full SIS Wiring...#72

Draft
frankxai with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-vercel-deployment-health-checks
Draft

[Updated] Phase 1 #1: Full SIS Wiring...#72
frankxai with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-vercel-deployment-health-checks

Conversation

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown

Summary

Production incident creation was firing on generic workflow failure, not specifically on failed post-deploy health checks. This PR narrows rollback/incident conditions to true health-check failures and removes blocking React lint patterns in the touched prompt-book UI paths so the pipeline can progress to deployment.

Changes

  • Workflow guardrails
    • Updated rollback gating in .github/workflows/mvp-deploy.yml to trigger only when health-check fails (needs.health-check.result == 'failure'), preventing false “production health check failed” incidents from pre-deploy job failures.
  • Prompt Books lint blockers
    • Refactored dropdown state usage in FilterBar.tsx to avoid render-time ref access patterns flagged by React lint.
    • Refined search modal close/reset flow in PromptSearch.tsx to avoid effect-driven synchronous state reset patterns that triggered cascade warnings/errors.
  • Sync status + particles purity fixes
    • Simplified online-state initialization in ConnectionStatus.tsx and removed unused imports.
    • Reworked StarField in particles.tsx to deterministic seeded values, eliminating render-time impure randomness violations.
# .github/workflows/mvp-deploy.yml
rollback:
  needs: [health-check]
  if: needs.health-check.result == 'failure' && github.ref == 'refs/heads/main'

Type

  • Feature (new functionality)
  • Fix (bug fix)
  • Refactor (code improvement, no behavior change)
  • Docs (documentation only)
  • Lore (universe content, Library texts)

Checklist

  • TypeScript compiles with zero errors (pnpm build)
  • Changes align with ARCANEA_CANON.md (if lore-related)
  • No new any types introduced
  • Tested locally or verified in Vercel preview

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
arcanea-2 Error Error Jun 16, 2026 9:31pm
arcanea-web Ready Ready Preview, Comment, Open in v0 Jun 16, 2026 9:31pm

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

Invalid vercel.json file provided

Copilot AI changed the title [WIP] Fix Vercel deployment health check issues Stabilize production health-check incident flow and unblock CI path to Vercel deploy Jun 16, 2026
Copilot AI requested a review from frankxai June 16, 2026 21:32
@frankxai frankxai changed the title Stabilize production health-check incident flow and unblock CI path to Vercel deploy [Updated] Phase 1 #1: Full SIS Wiring... Jun 17, 2026
frankxai added a commit that referenced this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚨 Production Deployment Failed - Health Check

2 participants