test: removed extraneous dependencies because of profiling tests#69
Merged
test: removed extraneous dependencies because of profiling tests#69
Conversation
Solution: moved the profiling test to a separate module. This sets a temporary trade-off, as a lot of test code (all test cases) have been hastily duplicated. We'll see in a forthcoming PR how to refactor test cases so they may be reusable by multiple modules. NOTE: it doesn't hurt if the new sub module requires a higher version of go. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 86.32% 86.32%
=======================================
Files 8 8
Lines 1002 1002
=======================================
Hits 865 865
Misses 133 133
Partials 4 4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: moved the profiling test to a separate module.
This sets a temporary trade-off, as a lot of test code (all test cases) have been hastily duplicated. We'll see in a forthcoming PR how to refactor test cases so they may be reusable by multiple modules.
NOTE: it doesn't hurt if the new sub module requires a higher version of go.