fix: preserve falsy assertion expected/actual values#578
Open
Sembauke wants to merge 2 commits intofreeCodeCamp:mainfrom
Open
fix: preserve falsy assertion expected/actual values#578Sembauke wants to merge 2 commits intofreeCodeCamp:mainfrom
Sembauke wants to merge 2 commits intofreeCodeCamp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug where failed test messages show
undefinedinstead of real values like0orfalse.The issue was that error values were only included when they were "truthy". That dropped valid falsy values (
0,false, and empty strings) fromexpectedandactual.This change keeps those values by checking whether the fields exist, instead of checking whether they are truthy.
I updated this in the JavaScript, DOM, and Python evaluators, and in the clone/fallback message path. I also added regression tests for JavaScript and DOM evaluators so this does not regress.
Closes freeCodeCamp/freeCodeCamp#64229