gluon-mesh-batman-adv: move wireless hop_penalty handling from gluon-core - #3810
Open
rotanid wants to merge 1 commit into
Open
gluon-mesh-batman-adv: move wireless hop_penalty handling from gluon-core#3810rotanid wants to merge 1 commit into
rotanid wants to merge 1 commit into
Conversation
github-actions
Bot
added
3. topic: docs
…core The batadv_hop_penalty option for wireless mesh interfaces was read in gluon-core's 200-wireless, mixing the batman-adv-specific option name into the generic wireless configurator. Move the read into a new gluon-mesh-batman-adv upgrade script (305) that runs after 200-wireless has created the mesh_<radio> network interfaces. Behavior is preserved: when gluon.band_X.batadv_hop_penalty is set, hop_penalty is applied to network.mesh_<radio>; when unset, it is left absent and gluon_bat0.sh defaults it to 0 at runtime (same as the previous 'or 0' fallback in 200-wireless). Also document the wireless band-scoped hop_penalty in gluon-mesh-batman-adv.rst alongside the existing wired/VPN variants.
rotanid
force-pushed
the
batadv-relocate
branch
from
August 19, 2026 02:08
3e2d3d8 to
a9f3545
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
batadv_hop_penaltyoption for wireless mesh interfaces was readin
gluon-core's200-wireless, mixing the batman-adv-specific optionname into the generic wireless configurator. Move the read into a new
gluon-mesh-batman-advupgrade script (305) that runs after200-wirelesshas created themesh_<radio>network interfaces.Changes
305-gluon-mesh-batman-adv-hop-penalty: iterates radios,reads
gluon.band_X.batadv_hop_penalty, and setshop_penaltyonexisting
network.mesh_<radio>sections (skipping radios where meshis not enabled).
batadv_hop_penaltyread from200-wireless(
gluon-core).batadv_hop_penaltyingluon-mesh-batman-adv.rstalongside the existing wired/VPN variants.Behavior
Preserved. When
gluon.band_X.batadv_hop_penaltyis set,hop_penaltyis applied to
network.mesh_<radio>; when unset, it is left absent andgluon_bat0.shdefaults it to0at runtime — equivalent to theprevious
or 0fallback in200-wireless.Background
Introduced in
17f59562("gluon-core: add hop_penalty support for meshinterfaces"), which extended wired/VPN hop_penalty support to wireless
but placed the read in
gluon-core. This PR completes the separationnoted by @neocturne in #3601: the
batadvstring should not appear ingluon-core.