gluon-core: fix silent failure of gluon-reconfigure on missing config - #3814
Open
maurerle wants to merge 1 commit into
Open
gluon-core: fix silent failure of gluon-reconfigure on missing config#3814maurerle wants to merge 1 commit into
maurerle wants to merge 1 commit into
Conversation
… files When a user deletes a configuration file (like /etc/config/gluon, dropbear, or firewall) to reset its state, lua-simple-uci silently ignores uci:set() and uci:save() failures. This causes gluon-reconfigure to falsely report success without actually applying the necessary configuration. This commit addresses the issue by: 1. Ensuring /etc/config/gluon is reliably recreated in gluon-reconfigure, so that deleting it intentionally acts as a proper reset. 2. Wrapping critical uci:set() and uci:save() calls in the upgrade scripts for gluon, dropbear, firewall, and network with lua's assert(). This forces these scripts to fail loudly on unexpected UCI errors (like missing files or read-only filesystems), causing gluon-reconfigure to report the failure properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user deletes a configuration file (like /etc/config/gluon, dropbear, or firewall) to reset its state, lua-simple-uci silently ignores uci:set() and uci:save() failures. This causes gluon-reconfigure to falsely report success without actually applying the necessary configuration.
This commit addresses the issue by:
This makes sure that gluon-reconfigure hints and configs which are misconfigured or missing