-
Notifications
You must be signed in to change notification settings - Fork 576
Further attempts at building with .NET 8 #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Numpsy
wants to merge
18
commits into
fsprojects:master
Choose a base branch
from
Numpsy:new8-build-bump-roll-tests-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
542ab45
Build with .NET 8.0:
Thorium d22f84e
try to run integration-tests with net6.0
Thorium b4a29ec
uninstall didn't seem to work well anyway
Thorium bb1b130
publish both test-artifacts, ensure test DirectorySeparatorChar
Thorium b9a0fa0
parentheses added
Thorium c9a64fb
integration tests back to 8
Thorium 4bcdd7d
typo fix
Thorium 81c8d26
fix merge
Numpsy ffa9a15
Try using the .NET 8 SDK for the resolver tests
Numpsy 8eb8a1a
Try to work around https://github.com/dotnet/sdk/issues/40655
Numpsy 1a35ce2
Because the system uses FSharp.Compiler.Service v43.8, the fsdocs-too…
Thorium fd720d0
Fix merge
Numpsy 61a05df
Try to get the template integration tests working by making them use …
Numpsy f50324d
update
Numpsy 8088ffd
Change SdkAssemblyResolver.SdkVersions to take an empty string to mea…
Numpsy 82f7bfc
In GetProductReleasesForSdk(), rename 'net60releases' to 'netReleases'
Numpsy ffe8b3d
Update the Microsoft.Build libraries from 17.11.4 to 17.11.48 to pick…
Numpsy 8120180
Update release notes
Numpsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ | |
| ] | ||
| }, | ||
| "fsdocs-tool": { | ||
| "version": "16.0.1", | ||
| "version": "20.0.1", | ||
| "commands": [ | ||
| "fsdocs" | ||
| ] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "sdk" : { | ||
| "version": "6.0.301", | ||
| "version": "8.0.401", | ||
| "rollForward": "latestMinor" | ||
| } | ||
| } |
2 changes: 1 addition & 1 deletion
2
integrationtests/core-reference-assemblies-net60100/before/global.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "sdk" : { | ||
| "version": "6.0.300" | ||
| "version": "8.0.400" | ||
| } | ||
| } |
2 changes: 1 addition & 1 deletion
2
integrationtests/core-reference-assemblies-net60101-rollforward/before/global.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "sdk" : { | ||
| "version": "6.0.300" | ||
| "version": "8.0.400" | ||
| } | ||
| } |
2 changes: 1 addition & 1 deletion
2
integrationtests/core-reference-assemblies-net60101/before/global.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "sdk" : { | ||
| "version": "6.0.301" | ||
| "version": "8.0.401" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the logic for this (or cachedDotnetSdkReleases.json) should be when updating .NET versions.
The current cachedDotnetSdkReleases.json only contains the .NET 6 releases and that seemed to cause test failures when built as .NET 8 and looking for the v8 SDK versions.
Changing this to 8.0 fixed that, but that might then not be right if fake-cli is multi-targetted at .NET 6 and .NET 8 as the .NET 6 version might still need the list of v6 releases?