fix: preserve existing files when checking FSMap write access - #2122
Merged
martindurant merged 1 commit intoSep 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening an
FSMapwithcheck=Truecan currently overwrite and delete an existing file nameda; anadirectory makes the check fail. Use a UUID-named write probe so the check leaves those existing entries intact and removes its own probe afterward.Validation
Post-Deploy Monitoring & Validation
For downstream adoption, check a populated mapper root with
check=Trueand compare its keys and bytes before and after. Missing entries or leftover probe files are regression signals; callers can temporarily usecheck=Falsewhile investigating. The regression tests cover this check for this PR; live cloud validation remains with backend adopters.Prepared and reviewed with Codex assistance. Review ran in the same agent session; no independent human review is claimed.