Add resumable downloads to get_file - #2128
Closed
nickita-khylkouski wants to merge 1 commit into
Closed
Conversation
Member
|
This is a very big PR and hard to review. I don't mind the idea of resumable downloads (open local file with "ab" and seek in remote file) not byte ranges, although the two conflict with each other. I think the implementation should be significantly simpler than this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1617.
Adds
resume=Truetoget_fileandgetfor local path destinations. The generic path opens an existing destination in append mode and seeks the remote file to the same offset. HTTP resumes with an internal range request, restarts safely if the server ignores it, and checks the remote size before accepting a completed local file. There is no public byte-range API.Tests:
stat -ccomparison cases fail on macOS with BSDstat