reference: keep get destinations inside the target - #2129
Merged
martindurant merged 1 commit intoSep 11, 2026
Conversation
Prevent reference-controlled paths from escaping the caller-selected local destination, while preserving paths that normalize within it.
stanislavfort
force-pushed
the
reference-get-check-contained
branch
from
September 11, 2026 09:28
0cc0c5e to
08c49cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReferenceFileSystem.get()allows reference keys containing..to write outside the caller-provided destination. This can overwrite local files when materializing an untrusted reference specification.#2103 added containment checks to the standard sync and async
get()paths, butReferenceFileSystemoverridesget()and writes its targets directly, so it bypasses those checks.This change applies the existing
check_contained()helper before any reference data is fetched or written.Tests
..paths that still resolve inside the destination.Full ReferenceFS test module: 24 passed, 13 skipped.