Forward Arrow file flush and closed state to the stream - #2134
Open
betacatsling wants to merge 1 commit into
Open
Forward Arrow file flush and closed state to the stream#2134betacatsling wants to merge 1 commit into
betacatsling wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrowFiledelegates writes and close to its Arrow stream but inheritsIOBase's no-op flush and independent closed flag. Buffered writes remain buffered afterflush(), and closed files reportclosed=False.Delegate
flushalongside the other stream methods, and report the stream's closed state. The regression uses a real buffered PyArrow output stream and covers context-managed readers/writers and external stream closure.On the unchanged base: 4 failed, 43 passed in the Arrow suite. With the fix, Arrow and core tests give 103 passed, 6 skipped on Linux/Python 3.12/PyArrow 25.0.1. Ruff lint/format and
git diff --checkpassed. No remote Arrow filesystem was used.AI assistance was used for implementation and local verification.
Fixes #2133.