This repository was archived by the owner on Jun 9, 2022. It is now read-only.
Fix #466 - make onTouchEnd click async#533
Open
michaelabuckley wants to merge 3 commits intoftlabs:mainfrom
Open
Fix #466 - make onTouchEnd click async#533michaelabuckley wants to merge 3 commits intoftlabs:mainfrom
michaelabuckley wants to merge 3 commits intoftlabs:mainfrom
Conversation
|
Is it going to merge someday? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain dom events (e.g. location change, ajax completion) seem to trigger touchend synchronously. When fastclick then generates the synthetic click, it arrives mid-stack and breaks some assumptions in angular (i.e. click events can't arrive during $digest). This PR changes wraps the sendClick() call with window.setTimeout to make sure it gets a clean stack.