feat: add svelte5 support with source-shipping packaging#18
Open
meherhowji wants to merge 3 commits into
Open
Conversation
ad585ef to
c597f57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
.sveltesource instead of a prebuilt file, so the same package works on both Svelte 4 and 5bind:chartwasn't ready in time, which broke the drill-down demoindex.d.ts)examples-v5/: a Vite + Svelte 5 app with 7 sample chartsExample fixes
renderAtprop everywhere, it never actually did anything (the wrapper renders into its own div), so it was just confusingonclickinstead ofon:click)Security
package-lock.jsonfrom the old build — it was flagging 3 High issues for packages we don't even use anymoredompurifyin the v5 exampleservedep from the v4 example and pinneduuid+http-proxy-middlewareto safe versionssvelte@4.2.20. That's the last Svelte 4 ever released and the fixes only exist in Svelte 5, so there's nothing to upgrade to. They're dev-only and never ship to anyone. If it matters, the answer is just to use Svelte 5, which this package now supports.Heads up (breaking change)
index.js/index.mjsare gone. You now need a bundler that understands Svelte (basically any Svelte setup already does).Still to do
examples,lib, etc.)