build: inject version via ldflags instead of committed VERSION file#363
Open
LorenzBischof wants to merge 1 commit into
Open
build: inject version via ldflags instead of committed VERSION file#363LorenzBischof wants to merge 1 commit into
LorenzBischof wants to merge 1 commit into
Conversation
Signed-off-by: LorenzBischof <1837725+LorenzBischof@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
//go:embed VERSIONmechanism with amain.versionvariable populated at build time via-ldflags. GoReleaser injects the git tag, so the binary still reports the right version and theVERSIONfile no longer needs to be committed and kept in sync. Also drops the VERSION-file write/commit step from the tag workflow (it now just creates the tag).Fixes #359