Rounding counts for queries with count responses#220
Conversation
|
I understand the concept but not the inline description (referring to handovers)? Also the naming is a bit strange.
Something like So: Yes to work on this (I'll see later...). |
|
As Michael points out, the descriptions in YAML are incorrect. |
This PR * renames the `PrecisionCount` to `CountPrecision`, in line with the `countPrecision` parameter name * removes the wrongly inserted description * adds/modifies descriptions
|
True, I forgot to remove the descriptions when recycling the Handovers entry to do the other entries. Thanks @mbaudis. |
|
See changes in #223 |
CountPrecision modification
|
Regarding the enum |
| type: | ||
| - integer | ||
| - string | ||
| minimum: 1 |
There was a problem hiding this comment.
Would be good to have examples.
There was a problem hiding this comment.
I agreed to be a reviewer for this at our last dev meeting, but I see that I've already commented on it. This looks good, but I'll repeat my main issue, that "rounded" does not describe all inexact cases (with the main example being differential privacy).
I'm not sure what the best fix is:
- change "rounded" to "inexact"
- there are only two values, so use a bool instead of an enum (called either "exact" or "inexact" depending on your preference for bool direction)
- add a third value to the enum to cover the case of inexact values that are not rounded. I don't have a value to suggest, in part because I can't think of one: something like "inexact" is not precise enough, since that applies to rounded values as well.
It would also be nice to have a general approach for numeric bins, but I think this is out of scope for this pr.
Descriptions still need to be cleaned up (including some json files where they are missing).
|
I'm with @gsfk here - "rounded" is just the wrong word; it doesn't have to be rounded - could be randomized, shuffled etc. (rounded is specific and if really rounded allows more backtracing). |
gsfk
left a comment
gsfk
left a comment
There was a problem hiding this comment.
Descriptions in beaconCountResponseSection{yaml, json} still need fixing (they're still a copypaste of the handovers description).
I'm not wild about the overlapping enums ("exact", "imprecise","rounded"), but I can live with them if everyone's really attached to keeping the term "rounded".
|
@gsfk we have removed the unnecessary descriptions |
4 participants
This PR aims to solve the problem of not showing the exact detailed results for a query. The solution gives the possibility to have a value for rounded counts between two integers, like between 20-30 or a string, like >30 (more than 30). @jrambla to explain more shortly.