You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sdelatorrep Thanks for starting this - and driving a great topic for standardisation & documentation!
I have problems mostly with the variantCount definition - but this may be me, coming from a "queries match multiple variants" background.
Generally, I do not think that those numbers have to mimic anything VCF, but rather that they can be computed from VCF numbers.
So:
variantCount should IMO be the number of distinct variants matched by a query. For most precise SNV queries, this would be just 1. However, for ranges/wildcards, this could be any number.
callCount doesn't make sense as the basic no. of alleles; it should (logically) be the number the queried variant(s) has/have been observed in the dataset; the sum of 2n(1/1) + 1n(1/0) + 1*n(0/1) ... However: This isn't of great interest (IMO), biologically, since you cannot decompose it into individual contributions from homo- and heterozygous ... matches. Useful would be a de-composition of the different call combinations (1/0, 1/1 ...); but I wouldn't know how to do this w/o running into a "if we can do this, we can ..." scenario.
So maybe we need to get back to the drawing board for "meaningful quantitative Beacon responses"?
Please, look at the presentation I've circulated based on the wiki page that Sabela has created but using an scaled down example.
For variantCount in wildcard/"multiple fuzzy variants", I would like to expand that in Beacon 2.0, but now, I guess that if we consider "any match" we should be returning them as if they were just "one", if someone is interested in specific variants, they can do that specific query. If someone wants to know about "which are the different variants" I believe we should refer to the "evidence" Beacon including the Variant SchemaBlock stuff.
I'm also believing that adding the karyotype details (1/1, 1/0...) could make sense, thus we can add counts for variantHomozygotesCount, variantHeterozygoteCount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.