Conversation
airhorns
approved these changes
Feb 9, 2026
airhorns
left a comment
airhorns
left a comment
Contributor
There was a problem hiding this comment.
, if it still doesnt work we can add an are the types wrong spec like we have elsewhere, it usually identifies the fuckery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using thumbdrive in a node project that uses an esm entrypoint; vite struggles to resolve thumbdrive due to the current package.json not containing the fields needed for esm module resolution rules
I also asked opus to add some more unhappy path tests