Coingecko router - #25
Draft
green-jay wants to merge 2 commits into
Draft
Conversation
cl0w5
approved these changes
Feb 6, 2024
Collaborator
|
@green-jay can you take care of the background job? (not needed anymore) |
Collaborator
Author
as in remove the job and schedule for it? |
Collaborator
Author
|
Update: router events are not emitted on every trade, so this needs to wait until we have generic trade events |
green-jay
marked this pull request as draft
February 27, 2024 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, queries were based on Omnipool trades. Since we now have router and multiple AMMs, we can base these queries on the router events, which is much more performant and elegant.
Update: router events are not emitted on every trade, so this needs to wait until we have generic trade events