Skip to content

feat: circuit breaker for deposit - #1142

Merged
mrq1911 merged 99 commits into
masterfrom
feat/deposit-lockdown
Jul 29, 2025
Merged

feat: circuit breaker for deposit#1142
mrq1911 merged 99 commits into
masterfrom
feat/deposit-lockdown

Conversation

@dmoka

@dmoka dmoka commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

TODO:

  • wait for last rebench commit of ref machine

  • grab benchmarks from bench machine

  • remove amount from release

  • create issue for untrapping assets as in XcmEchangeAsset we trap instead or reserve tokens when depost limit exceeds

  • rebench exchange asset too - worst case is buy as we calculate amount in too

  • wait for rebech of two LM pallets then replace

  • add action to set xcm-rate-limits for famous, birdged, sharetokens, etc assets. Limit should be also calibrated based on bug bounty values, making it always more profitable for a hacker to report the issue than to exploit it. MAYBE IT IS BETTER TO DETERMINE the daily mint, and multiplying it. Do a histogram, but not only how much we mint and how much we burn, so net mint should be calculated. We query daily net mint, and pick end of the historgram, without outliers

  • we need bot for unlocking assets

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown

Crate versions that have been updated:

  • runtime-integration-tests: v1.45.6 -> v1.46.0
  • pallet-circuit-breaker: v1.1.30 -> v1.2.0
  • pallet-currencies: v3.1.1 -> v3.2.0
  • pallet-hsm: v1.1.1 -> v1.1.2
  • pallet-omnipool: v5.0.8 -> v5.0.9
  • pallet-stableswap: v5.4.0 -> v5.4.1
  • hydradx-adapters: v1.8.0 -> v1.9.0
  • hydradx-runtime: v333.0.0 -> v334.0.0

Runtime version has been increased.

@dmoka
dmoka requested a review from martinfridrich July 25, 2025 06:11
Comment thread pallets/circuit-breaker/src/tests/lockdown_asset.rs Outdated
Comment thread integration-tests/src/deposit_limiter.rs Outdated
Comment thread runtime/hydradx/src/weights/pallet_omnipool.rs
Comment thread pallets/circuit-breaker/src/lib.rs Outdated
Comment thread pallets/circuit-breaker/src/lib.rs Outdated
@github-actions

Copy link
Copy Markdown

Quick benchmark at commit dc8dbb1 has been executed successfully.
View results

@mrq1911
mrq1911 merged commit 1e859ab into master Jul 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants