fix: use ema-oracle instead of spot price to calc. valued shares in xyk-liquidity-mining - #1153
Merged
Merged
Conversation
…use-oracle-to-value-shares
…use-oracle-to-value-shares
…use-oracle-to-value-shares
|
Crate versions that have been updated:
Runtime version has been increased. |
jak-pan
approved these changes
Jul 11, 2025
enthusiastmartin
approved these changes
Jul 12, 2025
enthusiastmartin
approved these changes
Jul 12, 2025
| type OraclePeriod: Get<OraclePeriod>; | ||
|
|
||
| /// XYK assets' liquidity oracle. | ||
| type LiquidityOracle: AggregatedOracle<AssetId, Balance, BlockNumberFor<Self>, pallet_ema_oracle::Price>; |
Member
There was a problem hiding this comment.
instead of price from ema oracle pallet. you can use EmaPrice from math package.
this way , you dont need to be dependent on pallet-ema-oracle.
…use-oracle-to-value-shares
… of pallet-ema-oracle::Price
…lacticcouncil/hydration-node into fix/xyk-lm-use-oracle-to-value-shares
…use-oracle-to-value-shares
…use-oracle-to-value-shares
martinfridrich
changed the base branch from
feat/ema-oracle-track-shares-issuance
to
master
July 14, 2025 15:18
|
Quick benchmark at commit 908bcce has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes xyk-liquidity-mining shares valuation to use ema-oracle pallet instead of spot price.
This PR depends on #1152