fix: add fallback price for global rate limiter - #1427
Merged
Conversation
…o onchain route for asset pair
dmoka
marked this pull request as ready for review
April 21, 2026 10:19
|
Crate versions that have been updated:
Runtime version has been increased. |
F3Joule
self-requested a review
April 21, 2026 11:34
F3Joule
reviewed
Apr 21, 2026
F3Joule
dismissed
their stale review
April 29, 2026 10:49
Reference currency generic is better to be removed making cod less abstract and more straightforward due to no need for other ref currency than HDX for now.
…port hdx as reference price so the design is more strict and safe
F3Joule
approved these changes
Apr 29, 2026
…ack prices too. then if not present, we falllback to oracle price
|
Quick benchmark at commit 13edaad has been executed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
external-asset withdraw/XCM returned FailedToConvertAsset whenever the oracle route was missing.
Adding onchain route is a quick fix, but better to add conversion using the fallback price if no oracle price can be retrieved