Update fasttree 2.1.10+galaxy1 to 2.1.10+galaxy3 in PathoGFAIR workflow.#1162
Update fasttree 2.1.10+galaxy1 to 2.1.10+galaxy3 in PathoGFAIR workflow.#1162jmchilton wants to merge 1 commit into
Conversation
|
I guess the bot has an update that would have caught this with https://github.com/galaxyproject/iwc/pull/758/changes - but that change is a lot more expansive. |
Both intermediate releases are Galaxy-level bug fixes with no input/output changes: - galaxy1→galaxy2: fix version_command (galaxyproject/tools-iuc#3114) - galaxy2→galaxy3: fix tool XML declaration (galaxyproject/tools-iuc#6640) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
62fee5d to
60bbc4b
Compare
|
Note Posted by Claude (AI assistant) on behalf of @jmchilton — not authored by them personally. Superseded by #1293, which carries this fasttree bump forward onto current Two reasons for a fresh PR rather than a rebase:
Worth flagging for whoever picks up #1293: the fasttree pin is what stops PathoGFAIR from being invoked at all, so its workflow test has effectively never run on CI. Fixing the pin lets it execute for the first time, which is likely why this PR went red back in March — it probably surfaced a downstream failure that is normally masked. #1293 will give a fresh, readable signal. The pin itself is confirmed still broken: the Toolshed's only installable fasttree revisions today are |
…ularization fasttree 2.1.10+galaxy1 is no longer installable from the toolshed (only 2.1.10 and 2.1.10+galaxy3 are), so the workflow could not be invoked and lint errored. Supersedes #1162, which bumped content_id/tool_id/changeset but left tool_version at +galaxy1 in all three fasttree steps. Also carries the class:Collection / collection_type test annotations for this workflow, split out of #1286. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Both intermediate releases are Galaxy-level bug fixes with no input/output changes:
The toolshed doesn't have the version listed in the workflow anymore - looking over galaxyproject/tools-iuc#6640 I can imagine why. My first thought was maybe we broke the tool loading in galaxyproject/galaxy#15493. But that behavior was trying to block on a tool version. The problem isn't immediately clear but I could put more time into if want to push back and call this a tool shed bug - I could try to re-implement boolean parameters that have matching truevalues and falsevalues if they are empty.
FOR CONTRIBUTOR:
FOR REVIEWERS:
This workflow does/runs/performs … xyz … to generate/analyze/etc …namefield should be human readable (spaces are fine, no underscore, dash only where spelling dictates it), no abbreviation unless generally understood-) over underscore (_), prefer all lowercase. Folder becomes repository in iwc-workflows organization and is included in TRS id