Adjust when 'Stack trace:' message is printed#6432
Conversation
972bb45 to
ae886cb
Compare
| <Log><![CDATA[ | ||
| gap> OnBreak := function() Where(0); end;; # eliminate back-tracing on | ||
| gap> # entry to break loop | ||
| gap> OnBreak := function() end;; # eliminate back-tracing on entry to break loop |
There was a problem hiding this comment.
This duplicates an example from debug.xml. Probably would be better to remove it here, and instead insert a link to the relevant section in debug.xml
There was a problem hiding this comment.
doc/tut/migrat.xml is not part of the Tutorial and should perhaps better be removed, cf. #6431.
There was a problem hiding this comment.
Ah I did not realize, thanks.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6432 +/- ##
==========================================
- Coverage 78.87% 78.87% -0.01%
==========================================
Files 685 685
Lines 293550 293543 -7
Branches 8672 8672
==========================================
- Hits 231530 231521 -9
- Misses 60211 60213 +2
Partials 1809 1809 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I prefer this over #6429. Maybe also print "Stacktrace:" instead of "Stack trace:"? |
ThomasBreuer
left a comment
There was a problem hiding this comment.
This looks good:
Do not print Stack trace if no stack follows,
but otherwise separate the error message from the numbered stack trace with a Stack trace line.
|
@lgoettgens I use "Stack trace" because that spelling (with a space) is how the GAP manual has spelled it for many years, and arguably it is the correct spelling (no compound words in English, unlike German). |
Alternative to and hence closes #6429.
This retains the
Stack trace:but now prints it more consistently (e.g. also when thebrowsepackage is used), and doesn't print it in pointless cases (when there is no stack trace)