Skip to content

Adjust when 'Stack trace:' message is printed#6432

Merged
fingolfin merged 3 commits into
masterfrom
mh/more-stacktrace-msg
Jun 8, 2026
Merged

Adjust when 'Stack trace:' message is printed#6432
fingolfin merged 3 commits into
masterfrom
mh/more-stacktrace-msg

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Alternative to and hence closes #6429.

This retains the Stack trace: but now prints it more consistently (e.g. also when the browse package is used), and doesn't print it in pointless cases (when there is no stack trace)

@fingolfin fingolfin force-pushed the mh/more-stacktrace-msg branch from 972bb45 to ae886cb Compare June 8, 2026 10:06
Comment thread doc/tut/migrat.xml
<Log><![CDATA[
gap> OnBreak := function() Where(0); end;; # eliminate back-tracing on
gap> # entry to break loop
gap> OnBreak := function() end;; # eliminate back-tracing on entry to break loop

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates an example from debug.xml. Probably would be better to remove it here, and instead insert a link to the relevant section in debug.xml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/tut/migrat.xml is not part of the Tutorial and should perhaps better be removed, cf. #6431.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I did not realize, thanks.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.87%. Comparing base (8187e9e) to head (ae886cb).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/error.g 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6432      +/-   ##
==========================================
- Coverage   78.87%   78.87%   -0.01%     
==========================================
  Files         685      685              
  Lines      293550   293543       -7     
  Branches     8672     8672              
==========================================
- Hits       231530   231521       -9     
- Misses      60211    60213       +2     
  Partials     1809     1809              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lgoettgens

Copy link
Copy Markdown
Member

I prefer this over #6429. Maybe also print "Stacktrace:" instead of "Stack trace:"?

@ThomasBreuer ThomasBreuer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good:
Do not print Stack trace if no stack follows,
but otherwise separate the error message from the numbered stack trace with a Stack trace line.

@fingolfin

Copy link
Copy Markdown
Member Author

@lgoettgens I use "Stack trace" because that spelling (with a space) is how the GAP manual has spelled it for many years, and arguably it is the correct spelling (no compound words in English, unlike German).

@fingolfin fingolfin merged commit a447d0e into master Jun 8, 2026
31 of 33 checks passed
@fingolfin fingolfin deleted the mh/more-stacktrace-msg branch June 8, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: error handling topic: library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants