Skip to content

FIX validate partially correct AEAT response lines - #36

Open
braito4 wants to merge 1 commit into
garacil:mainfrom
braito4:fix/validate-partial-aeat-response
Open

FIX validate partially correct AEAT response lines#36
braito4 wants to merge 1 commit into
garacil:mainfrom
braito4:fix/validate-partial-aeat-response

Conversation

@braito4

@braito4 braito4 commented Jul 27, 2026

Copy link
Copy Markdown

Summary

A global ParcialmenteCorrecto response can contain rejected (Incorrecto) records. The module previously treated every partial response as successful and could persist a rejected invoice or cancellation as sent.

This change:

  • accepts Correcto global responses
  • accepts a partial response only when every line is Correcto or AceptadoConErrores
  • rejects partial responses containing an Incorrecto, missing, or unknown line status
  • applies the same rule to invoice and cancellation responses

Validation

  • added seven focused response-status cases
  • tests pass on PHP 8.3, 8.4 and 8.5
  • PHP syntax and git diff --check pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant