Skip to content

FIX distinguish RechazoPrevio states #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
braito4 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX distinguish RechazoPrevio states #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions lib/newfenix/src/Invoice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,20 +222,20 @@ private function generateTimestamp(): string
* @param string $date Issue date
* @param string $taxId Issuer tax ID
* @param string $name Issuer name
* @param bool $priorRejection Whether correcting a rejection
* @param bool|null $priorRejection True if previously rejected by AEAT, null if it was never submitted
* @return self
*/
public static function createSubsanacion(
string $serial,
string $date,
string $taxId,
string $name,
bool $priorRejection = false
?bool $priorRejection = false
): self {
$instance = new self($serial, $date, $taxId, $name);
$instance->setAsCorrection(true);
if ($priorRejection) {
$instance->setAsPreviousRejection(true);
if ($priorRejection !== false) {
$instance->setAsPreviousRejection($priorRejection);
}
return $instance;
}
Expand Down Expand Up @@ -752,14 +752,14 @@ public function setAsCorrection(bool $isAmendment = true): self
/**
* Marks document as correction of prior rejection.
*
* @param bool $isPrior Prior rejection flag
* @param bool|null $isPrior True if rejected by AEAT, null if it was never submitted
* @return self
*/
public function setAsPreviousRejection(bool $isPrior = true): self
public function setAsPreviousRejection(?bool $isPrior = true): self
{
$this->statusFlags['isPriorRejection'] = $isPrior;
if ($isPrior) {
$this->payload['RechazoPrevio'] = 'X';
$this->statusFlags['isPriorRejection'] = ($isPrior !== false);
if ($isPrior !== false) {
$this->payload['RechazoPrevio'] = ($isPrior === true ? 'S' : 'X');
$this->setAsCorrection(true);
} else {
unset($this->payload['RechazoPrevio']);
Expand Down
33 changes: 33 additions & 0 deletions tests/PriorRejectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php

require_once __DIR__ . '/../lib/newfenix/src/Invoice.php';

use OpenAEAT\Billing\Invoice;

function getPriorRejectionValue(Invoice $invoice)
{
$property = new ReflectionProperty($invoice, 'payload');
$payload = $property->getValue($invoice);
return $payload['RechazoPrevio'] ?? null;
}

$invoice = new Invoice();
$invoice->setAsPreviousRejection(true);
if (getPriorRejectionValue($invoice) !== 'S') {
fwrite(STDERR, "Previously rejected records must use S\n");
exit(1);
}

$invoice->setAsPreviousRejection(null);
if (getPriorRejectionValue($invoice) !== 'X') {
fwrite(STDERR, "Records not previously submitted must use X\n");
exit(1);
}

$invoice->setAsPreviousRejection(false);
if (getPriorRejectionValue($invoice) !== null) {
fwrite(STDERR, "False must remove RechazoPrevio\n");
exit(1);
}

echo "All prior rejection tests passed\n";