FIX harden taxpayer identity and certificate handling - #41
Open
braito4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves VeriFactu integrity independently of MultiCompany support.
Changes
Immutable taxpayer identity
VERIFACTU_HOLDER_NIFafter the first fiscal record has entered the entity chainCertificate rotation remains possible; only the taxpayer identity that owns an existing chain is locked.
Certificate validation
0600permissionsOpenSSL command hardening
die()calls with exceptions that existing upload handling can report safelyA strict certificate-subject-to-taxpayer-NIF match is intentionally not imposed because the supported
normalcertificate mode allows personal and representative certificates.Validation
git diff --checkScope
This PR contains no MultiCompany-specific behavior. Cross-entity isolation, unique NIF/certificate enforcement between entities, and Multi-OT behavior remain in PR #34.