Skip to content

Add origin and credentials options #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kbambridge wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add origin and credentials options #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60a783c
feat(cors): Add --origin and --credentials options
kbambridge Oct 10, 2018
6c89da2
v1.1.1
kbambridge Oct 10, 2018
ed77c0d
build(yarn): yarn 1.10.1 has hashes saved yarn.lock
kbambridge Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bin/lcp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,20 @@ var optionDefinitions = [
type: String,
defaultValue: '/proxy'
},
{ name: 'proxyUrl', type: String }
{ name: 'proxyUrl', type: String },
{ name: 'origin', type: String, defaultValue: '*'},
{ name: 'credentials', type: Boolean, defaultValue: false}
];

try {
var options = commandLineArgs(optionDefinitions);
if (!options.proxyUrl) {
throw new Error('--proxyUrl is required');
}
lcp.startProxy(options.port, options.proxyUrl, options.proxyPartial);
lcp.startProxy(options.port, options.proxyUrl, options.proxyPartial, {
origin: options.origin,
credentials: options.credentials
});
} catch (error) {
console.error(error);
}
6 changes: 3 additions & 3 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ var cors = require('cors');
var chalk = require('chalk');
var proxy = express();

var startProxy = function(port, proxyUrl, proxyPartial) {
proxy.use(cors());
proxy.options('*', cors());
var startProxy = function(port, proxyUrl, proxyPartial, corsOptions) {
proxy.use(cors(corsOptions));
proxy.options('*', cors(corsOptions));

// remove trailing slash
var cleanProxyUrl = proxyUrl.replace(/\/$/, '');
Expand Down
14 changes: 10 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,26 @@
{
"name": "local-cors-proxy",
"version": "1.0.2",
"name": "dev-cors-proxy",
"version": "1.1.1",
"main": "./lib/index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"bin": {
"lcp": "./bin/lcp.js"
"dcp": "./bin/lcp.js"
},
"author": "Gary Meehan",
"license": "MIT",
"repository": {
"type": "git",
"url": "git+https://github.com/garmeeh/local-cors-proxy.git"
},
"keywords": ["cors", "proxy", "simple", "node", "express"],
"keywords": [
"cors",
"proxy",
"simple",
"node",
"express"
],
"bugs": {
"url": "https://github.com/garmeeh/local-cors-proxy/issues"
},
Expand Down
Loading