fix(thermal_camera): Fixed Gaussian noise for thermal camera.#597
Merged
iche033 merged 4 commits intogazebosim:gz-sensors8from Mar 18, 2026
Merged
fix(thermal_camera): Fixed Gaussian noise for thermal camera.#597iche033 merged 4 commits intogazebosim:gz-sensors8from
iche033 merged 4 commits intogazebosim:gz-sensors8from
Conversation
Signed-off-by: Martin Pecka <peci1@seznam.cz>
Signed-off-by: Martin Pecka <peci1@seznam.cz>
Signed-off-by: Martin Pecka <peci1@seznam.cz>
iche033
approved these changes
Mar 17, 2026
Contributor
iche033
left a comment
There was a problem hiding this comment.
changes here look good, thanks for the fix! Not sure if the noise will actually be applied to the thermal cameras though. We may need to extend gz-rendering with a custom render pass that adds gaussian noise to kelvin values instead of RGB values. Similar to special handling done by the ogre2 depth camera in gz-rendering
Signed-off-by: Martin Pecka <peci1@seznam.cz>
Contributor
|
@Mergifyio backport gz-sensors9 gz-sensors10 main |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
11 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
11 tasks
iche033
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
iche033
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
iche033
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
Contributor
|
@Mergifyio backport ign-sensors6 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
11 tasks
iche033
pushed a commit
that referenced
this pull request
Mar 19, 2026
Signed-off-by: Martin Pecka <peci1@seznam.cz> (cherry picked from commit 0e561e3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Thermal camera with Gaussian noise segfaults like this:
This PR fixes it by correctly using ImageNoiseFactory instead of NoiseFactory. This was probably forgotten in 6a00a58 .
This PR also adds the skipping of noise in case it is zero, as was done in #450 for other camera types.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.