Fix: Create BigNumber with NaN value in Dish.valid#2571
Open
sivachandran wants to merge 1 commit into
Open
Conversation
f2a838c to
edeb7ee
Compare
7eba8d2 to
51b9982
Compare
984bfd1 to
9504caf
Compare
The constructor expects the default value but we are not passing it. So it was throwing undefined error. Now passing NaN as default value.
9504caf to
8feb412
Compare
GCHQDeveloper581
requested changes
Jun 20, 2026
Comment on lines
-295
to
299
| const temp = new BigNumber(); | ||
| const temp = new BigNumber(NaN); | ||
| temp.c = this.value.c; | ||
| temp.e = this.value.e; | ||
| temp.s = this.value.s; | ||
| this.value = temp; |
Contributor
There was a problem hiding this comment.
better still,
this.value = new BigNumber({ s: this.value.s, e: this.value.e, c: this.value.c, _isBigNumber: true});
See
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The constructor expects the default value but we are not passing it. So it was throwing undefined error. Now passing NaN as default value.
Existing Issue
#2567
Screenshots

Console error
AI disclosure
Didn't use AI.
Test Coverage
Added a test.