Skip to content

Refactor waveguide models to use sax[rf] #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosavola merged 8 commits into from
Mar 31, 2026
Merged

Refactor waveguide models to use sax[rf] #344

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e4181e3
Refactor to use CPW and microstrip models from Sax
nikosavola Mar 13, 2026
8246dc6
Update sax dependency version to 0.16.14
nikosavola Mar 18, 2026
3f97da6
Potential fix for pull request finding
nikosavola Mar 18, 2026
8eccc37
Merge branch 'main' into refactor-waveguides-to-sax
nikosavola Mar 27, 2026
ac1d9a3
Merge remote-tracking branch 'origin/main' into refactor-waveguides-t…
nikosavola Mar 31, 2026
fdfc38e
Update Sax version
nikosavola Mar 31, 2026
dab1078
Refactor waveguide models to use sax.models.rf
Copilot Mar 31, 2026
2c1f6ba
Merge branch 'main' into refactor-waveguides-to-sax
nikosavola Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ models = [
"optuna",
"pymablock>=2.2.1",
"ray[tune]; sys_platform != 'win32'",
"sax>=0.16.11",
"sax[rf]>=0.16.11",
"scikit-rf",
"scqubits",
"sympy",
Expand Down
19 changes: 10 additions & 9 deletions qpdk/models/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,7 @@

sax.set_port_naming_strategy("optical")

from qpdk.models.constants import (
DEFAULT_FREQUENCY,
)
from qpdk.models.couplers import (
coupler_ring,
coupler_straight,
cpw_cpw_coupling_capacitance,
)
from qpdk.models.cpw import (
from sax.models.rf import (
cpw_epsilon_eff,
cpw_thickness_correction,
cpw_z0,
Expand All @@ -28,6 +20,15 @@
propagation_constant,
transmission_line_s_params,
)

from qpdk.models.constants import (
DEFAULT_FREQUENCY,
)
from qpdk.models.couplers import (
coupler_ring,
coupler_straight,
cpw_cpw_coupling_capacitance,
)
from qpdk.models.generic import (
admittance,
capacitor,
Expand Down
Loading
Loading