Skip to content

Fix all_models notebook lint suppression placement and readability issues #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikosavola merged 1 commit into from
Jul 1, 2026
Merged

Fix all_models notebook lint suppression placement and readability issues #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions notebooks/all_models.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,13 @@
"outputs": [],
"source": [
"\n",
"# ruff: disable[E402]\n",
"import jax.numpy as jnp\n",
"import matplotlib.pyplot as plt\n",
"\n",
"from qpdk import PDK\n",
"\n",
"PDK.activate()\n",
"\n",
"# ruff: disable[E402]"
"PDK.activate()"
]
},
{
Expand Down Expand Up @@ -317,7 +316,8 @@
"plt.legend()\n",
"plt.show(block=False)\n",
"\n",
"S_cap = capacitor(f=f, capacitance=(capacitance := 100e-15))\n",
"capacitance = 100e-15\n",
"S_cap = capacitor(f=f, capacitance=capacitance)\n",
"# print(S_cap)\n",
"plt.figure()\n",
"# Polar plot of S21 and S11\n",
Expand Down Expand Up @@ -356,7 +356,8 @@
"plt.title(f\"Capacitor $S$-parameters ($C={capacitance * 1e15}\\\\,$fF)\")\n",
"plt.show(block=False)\n",
"\n",
"S_ind = inductor(f=f, inductance=(inductance := 1e-9))\n",
"inductance = 1e-9\n",
"S_ind = inductor(f=f, inductance=inductance)\n",
"# print(S_ind)\n",
"plt.figure()\n",
"plt.subplot(121, projection=\"polar\")\n",
Expand Down Expand Up @@ -602,7 +603,7 @@
"source": [
"from qpdk.models.couplers import cpw_cpw_coupling_capacitance\n",
"\n",
"cpw_cpw_coupling_capacitance(TEST_FREQUENCY, 100, 100, \"cpw\")"
"cpw_cpw_coupling_capacitance(f=TEST_FREQUENCY, length=100, gap=100, cross_section=\"cpw\")"
]
},
{
Expand Down
11 changes: 6 additions & 5 deletions notebooks/src/all_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,14 @@

# %%

# ruff: disable[E402]
import jax.numpy as jnp
import matplotlib.pyplot as plt

from qpdk import PDK

PDK.activate()

# ruff: disable[E402]

# %% [markdown]
# ## Constants

Expand Down Expand Up @@ -174,7 +173,8 @@
plt.legend()
plt.show(block=False)

S_cap = capacitor(f=f, capacitance=(capacitance := 100e-15))
capacitance = 100e-15
S_cap = capacitor(f=f, capacitance=capacitance)
# print(S_cap)
plt.figure()
# Polar plot of S21 and S11
Expand Down Expand Up @@ -213,7 +213,8 @@
plt.title(f"Capacitor $S$-parameters ($C={capacitance * 1e15}\\,$fF)")
plt.show(block=False)

S_ind = inductor(f=f, inductance=(inductance := 1e-9))
inductance = 1e-9
S_ind = inductor(f=f, inductance=inductance)
# print(S_ind)
plt.figure()
plt.subplot(121, projection="polar")
Expand Down Expand Up @@ -372,7 +373,7 @@
# %%
from qpdk.models.couplers import cpw_cpw_coupling_capacitance

cpw_cpw_coupling_capacitance(TEST_FREQUENCY, 100, 100, "cpw")
cpw_cpw_coupling_capacitance(f=TEST_FREQUENCY, length=100, gap=100, cross_section="cpw")

# %%
from qpdk.models.couplers import coupler_straight
Expand Down
Loading