Add missing runtime dependencies (pandas, optax, tqdm)#94
Merged
Conversation
pandas, optax, and tqdm are imported unconditionally by modules loaded in sax/__init__.py but were not declared as runtime dependencies, causing ImportError for users installing sax without dev extras. Also adds import tests covering all affected submodules to prevent future dependency regressions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fit.py,interpolation.py,utils.py,parsers/touchstone.py,parsers/lumerical.pybut not declared as a dependencyfit.pybut only listed as a dev dependency (moved to runtime)fit.pybut not declared anywheretest_imports.pycovering all affected submodules to catch future dependency regressionsTest plan
pip install saxin a clean venv imports without errors🤖 Generated with Claude Code