Fix portless sub-netlists and internal-port handling#97
Merged
Conversation
- Filter out sub-netlists with no ports in circuit() to prevent errors during construction of hierarchical netlists. - Change default behavior for ports on internal connection nodes: drop them instead of auto-converting to probes. Add on_internal_port flag to circuit() with modes "warn" (default), "ignore", and "as_probes". - Update and add tests for both fixes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
circuit()to prevent errors during hierarchical netlist construction.on_internal_portparameter tocircuit()with three modes:"warn"(default): drop the port and emit a warning"ignore": drop the port silently"as_probes": convert to_fwd/_bwdprobe ports (legacy behavior)Test plan
test_circuit.pyfor portless sub-netlists (no ports key / empty ports dict)test_probes.pycovering all threeon_internal_portmodes, hierarchical composition port dropping, explicit probes after dropping, and probe-into-portless-subnetlist orderingpytest src/tests/ -v --ignore=src/tests/test_nbs.py)Closes #95, closes #96
🤖 Generated with Claude Code