Default to annotated tags rather than lightweight#66
Closed
patcon wants to merge 5 commits intogeddski:masterfrom
Closed
Default to annotated tags rather than lightweight#66patcon wants to merge 5 commits intogeddski:masterfrom
patcon wants to merge 5 commits intogeddski:masterfrom
Conversation
Author
|
If you'd like I can removed the If that is satisfactory for you, then I can work on documenting this. Just want confirmation before I do that bit of work :) Thanks! |
Author
|
Meh. Moved the signing stuff into other PR |
Author
|
Hm. Got this when didn't have a tagType in the config: |
Author
|
@geddski does anything else need to be done here? |
Owner
|
my understanding was that we're already using annotated tags. git docs says:
|
Author
|
Ah so we are. I guess I'll convert this into working for just signed commits and annotated tags. Thanks @geddski |
Collaborator
Author
|
As I remember, this was a non-issue since the default was already annotated...? I think we're good to close. |
Collaborator
|
Thanks for the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't been in the habit of doing this myself, but just learned that annotated tags are the best-practice:
http://git-scm.com/book/en/Git-Basics-Tagging#Creating-Tags
Worth switching the default for? Would seem that lightweight tags would be a good override