Skip to content

Default to annotated tags rather than lightweight#66

Closed
patcon wants to merge 5 commits intogeddski:masterfrom
patcon:66-annotated-tags
Closed

Default to annotated tags rather than lightweight#66
patcon wants to merge 5 commits intogeddski:masterfrom
patcon:66-annotated-tags

Conversation

@patcon
Copy link
Copy Markdown

@patcon patcon commented Feb 18, 2014

I haven't been in the habit of doing this myself, but just learned that annotated tags are the best-practice:
http://git-scm.com/book/en/Git-Basics-Tagging#Creating-Tags

Worth switching the default for? Would seem that lightweight tags would be a good override

@patcon
Copy link
Copy Markdown
Author

patcon commented Feb 18, 2014

If you'd like I can removed the signed case and could move that over to #65

If that is satisfactory for you, then I can work on documenting this. Just want confirmation before I do that bit of work :) Thanks!

@patcon
Copy link
Copy Markdown
Author

patcon commented Feb 18, 2014

Meh. Moved the signing stuff into other PR

@patcon
Copy link
Copy Markdown
Author

patcon commented Feb 20, 2014

Hm. Got this when didn't have a tagType in the config:

➜  roobot git:(master) grunt release
Running "release" task
>> bumped version to 0.0.2
>> staged package.json
>> committed package.json
Warning: Unrecognized tagType: "undefined". Use --force to continue.

@patcon
Copy link
Copy Markdown
Author

patcon commented Mar 18, 2014

Just noticed your commit @AsaAyers. Thanks for subsidizing my apparent laziness :)

I think this is ready to merge @geddski

@AsaAyers
Copy link
Copy Markdown

@geddski does anything else need to be done here?

@geddski
Copy link
Copy Markdown
Owner

geddski commented May 2, 2014

my understanding was that we're already using annotated tags. git docs says:

If -m or -F is given and -a, -s, and -u are absent, -a is implied.

@patcon
Copy link
Copy Markdown
Author

patcon commented May 2, 2014

Ah so we are. I guess I'll convert this into working for just signed commits and annotated tags. Thanks @geddski

@drublic
Copy link
Copy Markdown
Collaborator

drublic commented Jan 5, 2015

@patcon Thanks for your work. Is there anything to do here? Otherwise we could close this PR and work on #65 to get signed commits.

@patcon
Copy link
Copy Markdown
Author

patcon commented Jan 5, 2015

As I remember, this was a non-issue since the default was already annotated...? I think we're good to close.

@patcon patcon closed this Jan 5, 2015
@drublic
Copy link
Copy Markdown
Collaborator

drublic commented Jan 5, 2015

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants