fix: bind OAuth callback listener before browser auth - #260
Open
todor-roi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind the OAuth callback listener before any transport start/connect attempt can enter SDK OAuth and call
redirectToAuthorization().In
mcp-remote@0.1.38,StreamableHTTPClientTransport.start()/Client.connect()can trigger OAuth and open the browser beforeconnectToRemoteServer()catchesUnauthorizedErrorand callsauthInitializer(). If the user completes consent quickly, the provider redirects to loopback before the callback server is listening, causingERR_CONNECTION_REFUSED.This calls the existing
authInitializer()first. That path already starts the callback server and waits for thelisteningevent. The Unauthorized path then reuses that pre-bound auth state.Verification
pnpminstalled.