Skip to content

Rewrite package on typescript #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OldSkyTree wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rewrite package on typescript #23

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7d1c05
chore!: support nodejs from 12 version and above
Sep 12, 2022
415554c
chore: rename files *.js to *.ts
Feb 14, 2022
01c2536
chore: rewrite package on typescript
Feb 12, 2022
a5f33b9
build: configure eslint for typescript
Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
module.exports = {
extends: 'gemini-testing',
extends: ['gemini-testing', 'plugin:@typescript-eslint/recommended'],
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint'],
root: true

@DudaGod DudaGod Nov 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Немного странная последовательность опций. Я бы в такой последовательности описывал - https://github.com/gemini-testing/hermione-storybook/blob/master/.eslintrc.js

};
4 changes: 3 additions & 1 deletion lib/types/option.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ interface MetaInfo {
isSetByUser: boolean;
}

export interface OptionParserConfig<Value, MappedValue, Result> {
/* eslint-disable @typescript-eslint/no-explicit-any */
export interface OptionParserConfig<Value, MappedValue, Result = any> {

@DudaGod DudaGod Nov 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не понял а для чего ты тут столько any налупил? Давай хотя бы unknown юзать.

defaultValue?: Value | ((config: Result, currNode: any) => Value);
parseCli?: (input?: string) => Value | undefined;
parseEnv?: (input?: string) => Value | undefined;
validate?: (value: unknown, config: Result, currNode: any, meta: MetaInfo) => asserts value is Value;
map?(value: Value, config: Result, currNode: any, meta: MetaInfo): MappedValue;
isDeprecated?: boolean;
}
/* eslint-enable @typescript-eslint/no-explicit-any */

export interface OptionParser<Value, Result> {
(locator: Locator<Value>, config: Rooted<Result>): Value;
Expand Down
Loading