Skip to content

fix(ssh): use IP-style host placeholder#2502

Merged
arnestrickmann merged 1 commit into
mainfrom
emdash/ssh-setup-modal
Jun 12, 2026
Merged

fix(ssh): use IP-style host placeholder#2502
arnestrickmann merged 1 commit into
mainfrom
emdash/ssh-setup-modal

Conversation

@arnestrickmann

Copy link
Copy Markdown
Contributor

Summary

  • Update the SSH connection host placeholder from a domain example to an IP-style example.
  • Use documentation-range address 203.0.113.10 to avoid implying a real server.

Validation

  • pnpm exec oxfmt --check apps/emdash-desktop/src/renderer/lib/components/add-ssh-conn-modal.tsx

@arnestrickmann arnestrickmann marked this pull request as ready for review June 12, 2026 16:47
@arnestrickmann arnestrickmann merged commit ac9155f into main Jun 12, 2026
1 check passed
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the SSH connection host field placeholder from "example.com" to "203.0.113.10", a documentation-reserved IP address from the RFC 5737 TEST-NET-3 block (203.0.113.0/24), which is guaranteed never to be assigned to a real host.

  • The change is confined to a single placeholder prop in add-ssh-conn-modal.tsx, with no effect on validation, state, or submission logic.
  • Using a TEST-NET-3 address is a sensible choice: it signals that IP addresses are a valid input format while ensuring the example cannot be mistaken for or accidentally resolve to a real server.

Confidence Score: 5/5

Safe to merge — the change touches only a UI placeholder string with no effect on connection logic, validation, or state.

The diff is a single-character string swap in a placeholder prop. No validation rules, form handlers, RPC calls, or SSH logic are touched, making regression risk negligible.

No files require special attention.

Important Files Changed

Filename Overview
apps/emdash-desktop/src/renderer/lib/components/add-ssh-conn-modal.tsx Single-line change: host field placeholder updated from "example.com" to "203.0.113.10" (RFC 5737 TEST-NET-3 documentation address). No logic affected.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User opens Add SSH Connection modal] --> B[Host input field]
    B --> C{placeholder before PR}
    B --> D{placeholder after PR}
    C --> E["example.com (domain-style)"]
    D --> F["203.0.113.10 (RFC 5737 doc IP)"]
    B --> G[User types actual host/IP]
    G --> H[Form validation]
    H --> I[SSH connection attempt]
Loading

Reviews (1): Last reviewed commit: "fix(ssh): use IP-style host placeholder" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant