Skip to content

fix(sidebar): remove automations beta badge#2507

Merged
arnestrickmann merged 1 commit into
mainfrom
emdash/remove-beta-tag-automations
Jun 12, 2026
Merged

fix(sidebar): remove automations beta badge#2507
arnestrickmann merged 1 commit into
mainfrom
emdash/remove-beta-tag-automations

Conversation

@arnestrickmann

Copy link
Copy Markdown
Contributor

Summary

  • Removed the Beta badge from the Automations item in the left sidebar.
  • Cleaned up the unused badge import left behind by the UI change.

Impact

  • Automations now appears as a regular sidebar navigation item without a beta label.

Validation

  • corepack pnpm --filter @emdash/emdash-desktop run format:check
  • corepack pnpm --filter @emdash/emdash-desktop run typecheck
  • corepack pnpm --filter @emdash/emdash-desktop run lint

Note: lint completed with an existing warning in src/renderer/features/automations/use-automations.ts unrelated to this change.

@arnestrickmann arnestrickmann marked this pull request as ready for review June 12, 2026 23:11
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the "Beta" badge from the Automations navigation item in the left sidebar and cleans up the now-unused Badge import.

  • The <Badge variant="secondary">Beta</Badge> element is deleted from the Automations SidebarMenuButton, and the corresponding Badge import from @renderer/lib/ui/badge is removed — no other callers of Badge remain in this file.
  • The className="w-full justify-between" on the Automations button is left unchanged; it was meaningful when the badge was its second child, but is now a no-op since there is no right-aligned element remaining.

Confidence Score: 5/5

Safe to merge — the change removes three lines of JSX and one import with no logic impact.

The only substantive change is removing the Beta badge element and its import. The leftover justify-between class on the Automations button is harmless since a single flex child simply left-aligns regardless, but it is worth cleaning up for consistency with the sibling buttons.

No files require special attention.

Important Files Changed

Filename Overview
apps/emdash-desktop/src/renderer/features/sidebar/left-sidebar.tsx Removed Beta badge JSX and its unused Badge import from the Automations sidebar item; leaves a now-redundant justify-between class on the menu button.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[LeftSidebar] --> B[SidebarFooter]
    B --> C[SidebarSearchTrigger]
    B --> D["SidebarMenuButton — Automations\n(className: w-full justify-between)"]
    B --> E["SidebarMenuButton — Library\n(className: w-full justify-between)"]
    B --> F["SidebarMenuButton — Settings\n(className: w-full justify-between)"]

    D --> D1["span: Clock icon + 'Automations' text"]
    D -. "REMOVED" .-> D2["Badge: 'Beta'"]

    E --> E1["span: Library icon + 'Library' text"]
    E --> E2[BoundShortcut]

    F --> F1["span: Settings icon + 'Settings' text"]
    F --> F2[BoundShortcut]

    style D2 stroke-dasharray: 5 5, fill:#fee2e2, color:#991b1b
Loading

Comments Outside Diff (1)

  1. apps/emdash-desktop/src/renderer/features/sidebar/left-sidebar.tsx, line 71-73 (link)

    P2 Now that the Badge has been removed, the Automations button has only a single child element (the span), so justify-between has no second item to push to the opposite side. The other two footer buttons (Library, Settings) keep justify-between intentionally because they still have a BoundShortcut on the right. Dropping it here keeps the layout semantics consistent with what the class actually does.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: apps/emdash-desktop/src/renderer/features/sidebar/left-sidebar.tsx
    Line: 71-73
    
    Comment:
    Now that the Badge has been removed, the Automations button has only a single child element (the `span`), so `justify-between` has no second item to push to the opposite side. The other two footer buttons (`Library`, `Settings`) keep `justify-between` intentionally because they still have a `BoundShortcut` on the right. Dropping it here keeps the layout semantics consistent with what the class actually does.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/emdash-desktop/src/renderer/features/sidebar/left-sidebar.tsx:71-73
Now that the Badge has been removed, the Automations button has only a single child element (the `span`), so `justify-between` has no second item to push to the opposite side. The other two footer buttons (`Library`, `Settings`) keep `justify-between` intentionally because they still have a `BoundShortcut` on the right. Dropping it here keeps the layout semantics consistent with what the class actually does.

```suggestion
              onClick={() => navigate('automations')}
              aria-label="Automations"
              className="w-full"
```

Reviews (1): Last reviewed commit: "fix(sidebar): remove automations beta ba..." | Re-trigger Greptile

@arnestrickmann arnestrickmann merged commit e359c8f into main Jun 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant