Skip to content

add varesa - #2371

Merged
imring merged 20 commits into
genshinsim:mainfrom
imring:varesa
Sep 1, 2025
Merged

add varesa#2371
imring merged 20 commits into
genshinsim:mainfrom
imring:varesa

Conversation

@imring

@imring imring commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator
  • New character package
  • Config in character package
  • Run pipeline with added config (generates character curve, talent stats, .generated.json files)
  • Character key
  • Shortcuts for character key
  • Update mode_gcsim.js with shortcuts for syntax highlighting
  • Add Character package to imports
  • Normal Attack
  • Charge Attack / Aimed Shot
  • Skill
  • Burst
  • A1
  • A4
  • C1
  • C2
  • C3
  • C4
  • C5
  • C6
  • Other necessary talents (custom dash/jump, low/high plunge, ...)
  • Hitlag
  • ICD
  • StrikeType
  • PoiseDMG (blunt attacks only for now)
  • Hitboxes
  • Attack durability
  • Particles
  • Frames
  • Update documentation
  • Xingqiu/Yelan N0 (optional)
  • Xianyun Plunge (optional)

@imring imring added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Mar 27, 2025
@Charlie-Zheng

Charlie-Zheng commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

I need to fix substat optimizer for Varesa, her short burst will negatively affect how substat optimizer does the ER math.

Comment thread internal/characters/varesa/skill.go
Comment thread internal/characters/varesa/asc.go Outdated
Comment thread internal/characters/varesa/asc.go Outdated
Comment thread internal/characters/varesa/cons.go
Comment thread internal/characters/varesa/cons.go Outdated
Comment thread internal/characters/varesa/plunge.go
Comment thread internal/characters/varesa/attack.go Outdated
Comment thread internal/characters/varesa/attack.go
Comment thread internal/characters/varesa/attack.go
Comment thread internal/characters/varesa/attack.go Outdated
Comment thread internal/characters/varesa/burst.go Outdated
@imring
imring marked this pull request as ready for review August 15, 2025 17:59
Charlie-Zheng
Charlie-Zheng previously approved these changes Aug 29, 2025
@Charlie-Zheng

Copy link
Copy Markdown
Collaborator

Changes have been approved. Xianyun stuff can be added later when the frames are done being counted

Charlie-Zheng
Charlie-Zheng previously approved these changes Aug 31, 2025
@imring
imring merged commit e69e2df into genshinsim:main Sep 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants