Skirk c2 fix - #2442
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Cronkhinator on Discord:
On gcsim, the 70% ATK Skirk gets from using her mini burst also applies to the Void Rifts absorbed by that burst.
This does not happen ingame. Ingame, any Void Rifts absorbed by using her mini burst do not benefit from the 70% ATK buff.
I have compared the damage numbers ingame to what optimizer is giving me, and have confirmed that the damage caused by a C1 proc by her burst is missing exactly 70% ATK.
Here is a link to my gcsim config:
https://gcsim.app/sh/h8JwLmPjfcfw
I have also uploaded a video to google drive showing ingame behavior.
You can see the two void rifts absorbed by her burst hitting for 39640 damage, while the one absorbed by her charged attack a few seconds later hits for 49545 damage.
https://drive.google.com/file/d/1FsTRwRUaqQQ8W6gdOfHhGkD3jVpshprZ/view?usp=sharing