refactor reactions and combat events into info package; add reactable interface - #2467
Merged
Merged
Conversation
srliao
marked this pull request as draft
September 11, 2025 20:06
srliao
force-pushed
the
reactable-refactor-to-interface
branch
from
September 15, 2025 14:16
d589438 to
07603a6
Compare
srliao
marked this pull request as ready for review
September 15, 2025 14:16
srliao
changed the title
srliao
changed the title
srliao
changed the title
imring
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2468
Refactor out commonly used structs into
pkg/core/info