Skip to content

additional warn column for dbcompare based on percentage #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srliao merged 1 commit into from
Sep 16, 2025
Merged

additional warn column for dbcompare based on percentage #2471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions scripts/dbcompare/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,16 @@ type dbEntry struct {
}

type opts struct {
mustHaveChar string
iters int
workers int
mustHaveChar string
iters int
workers int
warnPerThreshhold float64
}

func main() {
var opt opts
flag.StringVar(&opt.mustHaveChar, "must", "", "comma separated character names that must be present, otherwise skip. default blank")
flag.Float64Var(&opt.warnPerThreshhold, "warn", 0.05, "percent difference threshold to warn on")
flag.IntVar(&opt.iters, "iters", 1000, "iterations to run each comparison")
flag.IntVar(&opt.workers, "workers", 30, "number of workers to use")
flag.Parse()
Expand All @@ -53,7 +55,7 @@ func main() {
panic(err)
}
filters := strings.Split(opt.mustHaveChar, ",")
fmt.Println("chars,id,original,next,diff,abs_diff,per_diff,err")
fmt.Println("diff_ok,chars,id,original,next,diff,abs_diff,per_diff,err")
for _, v := range res {
simcfg, gcsl, err := simulator.Parse(v.Config)
if err != nil {
Expand Down Expand Up @@ -86,7 +88,11 @@ func main() {
diff := dps - v.Summary.MeanDpsPerTarget
absDiff := math.Abs(diff)
percentDiff := absDiff / v.Summary.MeanDpsPerTarget
fmt.Printf("%v,%v,%v,%v,%v,%v,%v,%v\n", team, v.Id, v.Summary.MeanDpsPerTarget, dps, diff, absDiff, percentDiff, err)
warn := "ok"
if percentDiff > opt.warnPerThreshhold {
warn = "WARNING"
}
fmt.Printf("%v,%v,%v,%v,%v,%v,%v,%v,%v\n", warn, team, v.Id, v.Summary.MeanDpsPerTarget, dps, diff, absDiff, percentDiff, err)
}
}

Expand Down