Skip to content

CI: add ASAN, UBSAN #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thesamesam wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CI: add ASAN, UBSAN #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f57111d
CI: add ASAN, UBSAN
thesamesam Jan 6, 2023
45c949e
CI: run on all events
thesamesam Jan 6, 2023
71a5a1b
CI: disable fail-fast
thesamesam Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions .github/workflows/build-test-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,22 @@

name: Build+Test CI

on:
push:
branches:
- master
tags:
- v*
pull_request:
types:
- opened
branches:
- master
on: [pull_request, push]

jobs:
make-check-ubuntu-x64:
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
cc:
- gcc
- clang
sanitizer:
- none
- asan
- ubsan
features:
- --enable-qmanifest --enable-qtegrity
- --disable-qmanifest --enable-qtegrity
Expand All @@ -33,6 +28,8 @@ jobs:
runs-on: ${{ matrix.os }}
env:
CC: ${{ matrix.cc }}
ASAN_OPTIONS: "detect_leaks=0" # TODO: poke at leaks in atom_explode/dotest
SANITIZER: ${{ matrix.sanitizer }}
steps:
- name: install deps
run: >
Expand All @@ -45,7 +42,25 @@ jobs:
--disable-maintainer-mode --disable-openmp
${{ matrix.features }}
- name: make variant ${{ matrix.features }}
run: make CFLAGS="-O3 -Wall -Wshadow -pipe" V=1 check
run: >
export CFLAGS="-O3 -Wall -Wshadow -pipe"
export ASAN_OPTIONS="${ASAN_OPTIONS}:halt_on_error=1:abort_on_error=1:print_summary=1"
export UBSAN_OPTIONS="${UBSAN_OPTIONS}:halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1"

case "$SANITIZER" in
none)
;;
asan)
export CFLAGS="${CFLAGS} -ggdb3 -fsanitize=address"
Copy link
Copy Markdown
Member

@grobian grobian Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it useful to use -O3 here? do we get useful stacks and analysis this way? For valgrind we also run with -g -pipe to get understandable complaints

export LDFLAGS="-fsanitize=address"
;;
ubsan)
export CFLAGS="${CFLAGS} -ggdb3 -fsanitize=undefined"
export LDFLAGS="-fsanitize=undefined"
;;
esac

make CFLAGS="${CFLAGS}" V=1 check

# I'm too tired for now to make it work
# make-check-macos-x64:
Expand Down