Skip to content

avoid using 'l' as variable#1356

Open
maekke wants to merge 2 commits intogentoo:masterfrom
maekke:improve_ambiguous_name
Open

avoid using 'l' as variable#1356
maekke wants to merge 2 commits intogentoo:masterfrom
maekke:improve_ambiguous_name

Conversation

@maekke
Copy link
Copy Markdown
Contributor

@maekke maekke commented Jul 3, 2024

as detected by ruff. try to use a more meaningful variable name instead.

maekke added 2 commits July 3, 2024 16:07
as detected by ruff. try to use a more meaningful variable name instead.
@floppym
Copy link
Copy Markdown
Contributor

floppym commented Jul 3, 2024

This feels pretty pointless to me.

@ajakk
Copy link
Copy Markdown
Member

ajakk commented Jul 4, 2024

Do you propose that some combination of ruff+black be used for Portage? I note that you have some black fixes in this PR, do we know why we're not seeing complaints for those in CI?

@eli-schwartz
Copy link
Copy Markdown
Member

The black fixes in this PR aren't actually black fixes for portage. They are the classic case of "my first commit introduced some linter errors, so I added a second commit to fix the first commit instead of using git commit --amend".

@eli-schwartz
Copy link
Copy Markdown
Member

Overall I agree this seems pointless. Using i as an iteration variable in a loop isn't a bad thing, even if you spell it as an "L" instead.

There are varying opinions on this, obviously. I commented about the general concept on the ruff issue tracker, in fact. :D astral-sh/ruff#4866 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants