Open
Conversation
as detected by ruff. try to use a more meaningful variable name instead.
Contributor
|
This feels pretty pointless to me. |
Member
|
Do you propose that some combination of ruff+black be used for Portage? I note that you have some black fixes in this PR, do we know why we're not seeing complaints for those in CI? |
Member
|
The black fixes in this PR aren't actually black fixes for portage. They are the classic case of "my first commit introduced some linter errors, so I added a second commit to fix the first commit instead of using |
Member
|
Overall I agree this seems pointless. Using There are varying opinions on this, obviously. I commented about the general concept on the ruff issue tracker, in fact. :D astral-sh/ruff#4866 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as detected by ruff. try to use a more meaningful variable name instead.