feature: Add Annotations to Measurements#992
Conversation
2387951 to
e4e57cb
Compare
|
This looks great and I think some of the people that use our site will be really excited by this! I have some thoughts on how the measure units change for area when you switch between length and area. I think it makes sense that changing length units from feet to meters will change area units from sq. feet to sq. meters. I think it's less obvious for chains (and rods - which isn't in the demo but is an option in the underlying code). I was talking with the surveyors in our office about what would be intuitive to them, as they're the ones that tend to use chains and rods, and they recommended Acres, over square feet (which is what chains defaults to) and square rods (which rods defaults to - though I'm not sure if square rods can be set in the configuration, so it looks like the user has no area unit selected). My only other comment is if the configuration for turning the units off by default should be with the other measure configurations: |
|
@chughes-lincoln , just pushed some changes based on your earlier feedback. We could turn off label suppression? That would ensure all the little bits are coming through but would be, ultimately, much uglier when it's dense. |
|
I think those changes are good. Overall I like how the labels are suppressed for user-added lines/polygons more than I dislike how they're suppressed for features from results. People capable enough to measure features from results probably know enough to zoom in to see all the labels. |
|
Not sure if I followed Chris' last comment, but I wanted to agree that users will really like this feature! I think that's particularly true for things that users draw on the map, and think this feature can be used in conjunction with regular sketches in interesting ways. |
- Ensure area labels are clearly marked. - Add a labels toggle to the map based on whether there are measure features. - Add an "active" state to map buttons to show it is "on" - Provide translations for the new measurement toggles. - Adds tests - Document how to turn label for measurements off by default.
329c18d to
26f5f68
Compare
|
Is this one ready to merge or still under discussion? |
|
Looks good to me |


Adds new annotations for measurements:
Which can also be toggled off with the new labels toggle: